Page tree

Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

This will put you into an editor to update your commit comment, and when you save it will commit the change locally. The -v option appends the diff to the edit buffer so you can review what is about to be committed. This is very useful to verify that you are committing what you want to commit, and not changes or files that are unrelated to the current change.  The -s option adds a Signed-off-by: line to the commit message, which is required for all patches submitted to DAOS.

...

In conjunction with the two review requests, the patch has to successfully build on all supported architecture/distro combinations, and pass the automatic testing (as reported by Maloo). Once the patch has passed two reviews (+1 or +2 Review from reviewers that are not the original developer), built correctly (+1 Verified from Jenkins), and has passed autotest (+1 Verified from Maloo) the patch will automatically appear in the Gerrit Gatekeeper's list of patches to land.

...